Uploaded image for project: 'Seam 2'
  1. Seam 2
  2. JBSEAM-3952

log-level/logLevel default should be LogLevel.error but it is null

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 2.1.0.SP1, 2.1.1.CR1, 2.1.1.CR2, 2.1.1.GA
    • Fix Version/s: 2.1.2.CR1
    • Component/s: None
    • Labels:
      None

      Description

      In the manual (http://docs.jboss.com/seam/2.1.1.GA/reference/en-US/html/events.html#d0e5611) at 6.12.4.1. Suppressing exception logging one can read:

      " If the logLevel is not specified, or if an invalid value is configured, then it will default to error. "

      But In org.jboss.seam.exception.Exceptions in the parse method:

      LogLevel logLevel = LogLevel.error; <--- THIS LINE IS IRRELEVANT
      try
      {
      logLevel = exception.attributeValue("log-level") != null ?
      LogLevel.valueOf(exception.attributeValue("log-level").toLowerCase()) : null; //<--- THIS 2 LINES SET IT TO NULL

      // The logLevel attribute is deprecated! Use log-level instead
      if (logLevel == null && exception.attributeValue("logLevel") != null)

      { logLevel = LogLevel.valueOf(exception.attributeValue("logLevel").toLowerCase()); }

      The line (168,169) sets the logLevel to null if it does not find the attribute in the .xml attribute, making the line 165 irrelevant, the actual default becomes "null"

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                norman.richards Norman Richards
                Reporter:
                luxspes Francisco Jose Peredo Noguez
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: