Any error in the package installation workflow is silently ignored

Any error in the package installation steps that is reported using the error() method in the step handlers is silently ignored.

The plugins share a common library that implements the common functionality for package installation including a number of installation step handlers. Both AS4 and AS5 plugins include this as a dependent jar in their /lib directory.

In this library the error() method implemented in BaseHandler class uses StringUtil class from RHQ clientapi.

At runtime the following exception is thrown:

org.jbpm.graph.def.DelegationException
at org.jbpm.graph.def.GraphElement.raiseException(GraphElement.java:349)
at org.jbpm.graph.def.GraphElement.raiseException(GraphElement.java:343)
at org.jbpm.graph.def.GraphElement.raiseException(GraphElement.java:343)
at org.jbpm.graph.def.Node.execute(Node.java:332)
at org.jbpm.graph.def.Node.enter(Node.java:316)
at org.jbpm.graph.def.Transition.take(Transition.java:119)
at org.jbpm.graph.def.Node.leave(Node.java:382)
at org.jbpm.graph.node.StartState.leave(StartState.java:70)
at org.jbpm.graph.exe.Token.signal(Token.java:174)
at org.jbpm.graph.exe.Token.signal(Token.java:123)
at org.jbpm.graph.exe.ProcessInstance.signal(ProcessInstance.java:217)
at org.jboss.on.common.jbossas.JBPMWorkflowManager.run(JBPMWorkflowManager.java:156)
at org.rhq.plugins.jbossas5.ApplicationServerContentFacetDelegate.deployPackages(ApplicationServerContentFacetDelegate.java:110)
at org.rhq.plugins.jbossas5.ApplicationServerComponent.deployPackages(ApplicationServerComponent.java:279)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.rhq.core.pc.inventory.ResourceContainer$ComponentInvocationThread.call(ResourceContainer.java:525)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:619)
Caused by: java.lang.NoClassDefFoundError: org/rhq/core/clientapi/util/StringUtil
at com.jboss.jbossnetwork.product.jbpm.handlers.BaseHandler.logStep(BaseHandler.java:258)
at com.jboss.jbossnetwork.product.jbpm.handlers.BaseHandler.error(BaseHandler.java:155)
at com.jboss.jbossnetwork.product.jbpm.handlers.JONServerDownloadActionHandler.run(JONServerDownloadActionHandler.java:57)
at com.jboss.jbossnetwork.product.jbpm.handlers.BaseHandler.execute(BaseHandler.java:135)
at org.jbpm.graph.def.Action.execute(Action.java:123)
at org.jbpm.graph.def.Node.execute(Node.java:328)
... 20 more

but JBPMWorkflowManager merely logs this exception and continues without rethrowing it. The calling code then errorneously thinks that everything succeeded when it didn't.